feat: support for enclave migration in React Native #4992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1994d9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
joaquim-verges
requested review from
MananTank,
edwardysun,
gregfromstl and
jnsdls
as code owners
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Contributor
size-limit report 📦
|
joaquim-verges
force-pushed
the
10-11-feat_support_for_enclave_migration_in_react_native
branch
from
7e1da43 to
4ee5662
Compare
joaquim-verges
force-pushed
the
10-11-feat_support_for_enclave_migration_in_react_native
branch
from
4ee5662 to
eab1aae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4992 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 1058 1058
Lines 54670 54672 +2
Branches 3950 3950
=======================================
+ Hits 24757 24758 +1
- Misses 29222 29223 +1
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Member
Author
Merge activity
|
joaquim-verges
force-pushed
the
10-11-feat_support_for_enclave_migration_in_react_native
branch
from
eab1aae to
62cca6d
Compare
joaquim-verges
force-pushed
the
10-11-feat_support_for_enclave_migration_in_react_native
branch
from
62cca6d to
d742f6c
Compare
joaquim-verges
force-pushed
the
10-11-feat_support_for_enclave_migration_in_react_native
branch
from
d742f6c to
27bdf0a
Compare
gregfromstl
approved these changes
Oct 14, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `thirdweb` package by introducing support for enclave wallet migration in React Native and updating relevant dependencies, including `@thirdweb-dev/react-native-adapter`.
### Detailed summary
- Added support for enclave wallet migration in React Native.
- Updated dependency versions for `@thirdweb-dev/react-native-adapter` and `thirdweb`.
- Changed how `ecosystemId` is handled in multiple files to use an object structure.
- Enhanced error handling in wallet recovery functions.
- Updated `ConnectedButton`, `ConnectedModal`, and other UI components to accept `client` prop.
- Introduced migration functionality in `migrateToEnclaveWallet`.
- Refactored wallet-related actions to improve code consistency and structure.
> The following files were skipped due to too many changes: `pnpm-lock.yaml`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
10-11-feat_support_for_enclave_migration_in_react_native
branch
from
1f06132 to
1994d9e
Compare
graphite-app
bot
deleted the
10-11-feat_support_for_enclave_migration_in_react_native
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
thirdweblibrary with support for enclave wallet migration in React Native, along with updates to dependencies and improvements in error handling and wallet management.Detailed summary
@thirdweb-dev/react-native-adapter.ecosystemIdreferences toecosystemin several files.guest.tsand other authentication files.WalletImagecomponent to acceptclientprop.migrateToEnclaveWalletfunction for migration logic.